feat(kms-connector): retrieve s3 url in extra_data#812
Closed
eudelins-zama wants to merge 5 commits intofeat/coprocessor_contexts_in_gatewayfrom
Closed
feat(kms-connector): retrieve s3 url in extra_data#812eudelins-zama wants to merge 5 commits intofeat/coprocessor_contexts_in_gatewayfrom
eudelins-zama wants to merge 5 commits intofeat/coprocessor_contexts_in_gatewayfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the KMS connector to retrieve S3 URLs from extra_data instead of querying the GatewayConfig contract. The main change involves replacing the coprocessor address-based S3 URL lookup with direct URL extraction from request metadata.
- Removes dependency on GatewayConfig contract for S3 URL retrieval
- Implements S3 URL matrix decoding from extra_data field
- Removes coprocessor address tracking from SNS ciphertext materials
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| kms-connector/simple-connector/Cargo.toml | Updates dashmap dependency specification |
| kms-connector/crates/utils/src/types/db.rs | Removes coprocessor address field from database types |
| kms-connector/crates/utils/src/tests/rand.rs | Updates test data generation to exclude coprocessor addresses |
| kms-connector/crates/kms-worker/tests/s3.rs | Simplifies S3Service instantiation by removing provider dependency |
| kms-connector/crates/kms-worker/src/core/kms_worker.rs | Updates type signatures to remove provider generic |
| kms-connector/crates/kms-worker/src/core/event_processor/s3.rs | Major refactor replacing contract-based URL lookup with extra_data parsing |
| kms-connector/crates/kms-worker/src/core/event_processor/processor.rs | Removes provider generic from processor types |
| kms-connector/crates/kms-worker/src/core/event_processor/decryption.rs | Implements S3 URL matrix decoding and adds corresponding tests |
| kms-connector/crates/kms-worker/Cargo.toml | Removes dashmap dependency |
| kms-connector/connector-db/migrations/20250902144114_update_sns_ciphertext.sql | Database migration to remove coprocessor address column |
| kms-connector/Cargo.toml | Updates fhevm_gateway_bindings revision and removes dashmap dependency |
Comments suppressed due to low confidence (1)
kms-connector/crates/kms-worker/src/core/event_processor/decryption.rs:1
- This extremely long hex string constant should be split into multiple lines or stored in a separate test data file for better readability and maintainability.
use crate::core::{
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
kms-connector/crates/kms-worker/src/core/event_processor/decryption.rs
Outdated
Show resolved
Hide resolved
eudelins-zama
force-pushed
the
simon/feat/404/s3-url-without-gateway
branch
from
b38f7da to
c67662a
Compare
eudelins-zama
force-pushed
the
simon/feat/404/s3-url-without-gateway
branch
from
4cd7fa9 to
9897f9c
Compare
melanciani
reviewed
Sep 4, 2025
dartdart26
approved these changes
Sep 5, 2025
eudelins-zama
force-pushed
the
simon/feat/404/s3-url-without-gateway
branch
3 times, most recently
from
172ca75 to
780febc
Compare
melanciani
reviewed
Sep 23, 2025
kms-connector/crates/kms-worker/src/core/event_processor/decryption.rs
Outdated
Show resolved
Hide resolved
melanciani
requested changes
Sep 23, 2025
Contributor
melanciani
left a comment
melanciani
left a comment
There was a problem hiding this comment.
small change: storage urls are no longer in extraData and can be found as a new field in the request event
eudelins-zama
force-pushed
the
simon/feat/404/s3-url-without-gateway
branch
from
780febc to
d04ee84
Compare
Contributor
Author
|
Should be good now @RomanBredehoft (cc @dartdart26) |
melanciani
reviewed
Sep 25, 2025
Add support for a separate uin256 context ID in the event listened to by the gw-listener and using it to sign a `CiphertextVerification` in transaction-sender. Related to #211
chore(kms-connector): update mock contract address chore(kms-connector): remove gw conn from kms-worker chore(kms-connector): update extra_data encoding fix(kms-connector): fix kms-worker health tests chore(kms-connector): adapt storage urls retrieval chore(kms-connector): s3 urls edge case handling
eudelins-zama
force-pushed
the
simon/feat/404/s3-url-without-gateway
branch
from
aaea886 to
92f278a
Compare
dartdart26
force-pushed
the
feat/coprocessor_contexts_in_gateway
branch
from
29b4ec8 to
0bb20fb
Compare
melanciani
force-pushed
the
feat/coprocessor_contexts_in_gateway
branch
from
0bb20fb to
390c08a
Compare
Contributor
Author
|
Closing, no longer wanted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref https://github.com/zama-ai/fhevm-internal/issues/404